-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pacifico: Version 3.010; ttfautohint (v1.8.4.7-5d5b) added #7104
Conversation
…b) added * Pacifico Version 3.010; ttfautohint (v1.8.4.7-5d5b) taken from the upstream repo https://github.com/Black-sage/Pacifico at commit Black-sage/Pacifico@5274c92.
FontBakery reportfontbakery version: 0.10.7 [1] Experimental checks🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
[code: failed-language-shaping] [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[25] Pacifico-Regular.ttf🔥 FAIL: Does DESCRIPTION file contain broken links? (com.google.fonts/check/description/broken_links)
🔥 FAIL: Check OFL body text is correct. (com.google.fonts/check/license/OFL_body_text)
🔥 FAIL: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field. (com.google.fonts/check/metadata/consistent_repo_urls)
But: font copyright string has 'https://github.com/googlefonts/Pacifico', OFL text has 'https://github.com/googlefonts/Pacifico' and HTML description has 'github.com/googlefonts/Pacifico' 🔥 FAIL: Checking with fontTools.ttx (com.google.fonts/check/ttx_roundtrip)
⚠ WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: Glyphs are similiar to Google Fonts version? (com.google.fonts/check/production_glyphs_similarity)
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours:
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
Use -F or --full-lists to disable shortening of long lists. [code: found-colinear-vectors] ⚠ WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
Use -F or --full-lists to disable shortening of long lists. [code: found-jaggy-segments] ⚠ WARN: Do outlines contain any semi-vertical or semi-horizontal lines? (com.google.fonts/check/outline_semi_vertical)
Use -F or --full-lists to disable shortening of long lists. [code: found-semi-vertical] ⚠ WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
The dot of soft dotted characters should disappear in other cases, for example: ḭ̀ ḭ́ ḭ̂ ḭ̃ ḭ̄ ḭ̆ ḭ̇ ḭ̈ ḭ̉ ḭ̊ ḭ̋ ḭ̌ ḭ̏ ḭ̑ ḭ̒ і̀ і̂ і̃ і̄ і̆ Your font fully covers the following languages that require the soft-dotted feature: Ukrainian (Cyrl, 29,273,587 speakers), Belarusian (Cyrl, 10,064,517 speakers), Lithuanian (Latn, 2,357,094 speakers). Your font does not cover the following languages that require the soft-dotted feature: Avokaya (Latn, 100,000 speakers), Koonzime (Latn, 40,000 speakers), Bafut (Latn, 158,146 speakers), Nateni (Latn, 100,000 speakers), Nzakara (Latn, 50,000 speakers), Mango (Latn, 77,000 speakers), Dutch (Latn, 31,709,104 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Basaa (Latn, 332,940 speakers), Navajo (Latn, 166,319 speakers), Lugbara (Latn, 2,200,000 speakers), Igbo (Latn, 27,823,640 speakers), Dan (Latn, 1,099,244 speakers), Ejagham (Latn, 120,000 speakers), Fur (Latn, 1,230,163 speakers), Ma’di (Latn, 584,000 speakers), Zapotec (Latn, 490,000 speakers), Sar (Latn, 500,000 speakers), Gulay (Latn, 250,478 speakers), Kom (Latn, 360,685 speakers), Aghem (Latn, 38,843 speakers), South Central Banda (Latn, 244,000 speakers), Ebira (Latn, 2,200,000 speakers). [code: soft-dotted] ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535: ℹ INFO: Familyname must be unique according to namecheck.fontdata.com (com.google.fonts/check/fontdata_namecheck)
ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Summary
Note: The following loglevels were omitted in this report:
|
🔥 FAIL: Does DESCRIPTION file contain broken links? 🔥 FAIL: Check OFL body text is correct 🔥 FAIL: Check copyright namerecords match license file. 🔥 FAIL: Checking with fontTools.ttx 🔥 FAIL: METADATA.pb: Check URL on copyright string is the same as in repository_url field. ⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? |
@emmamarichal i pinged @Black-sage about this yesterday and he says he'll fill in the profile form shortly :) Those FB issues all seem fine to ignore to me. @felipesanches @simoncozens note these fb result exceptions that we want to resolve as a priority :) |
I'll maybe change the designer name in metadatas, according the answer I'll get here: #7151 |
I'd like this PR to be kept open until my GlyphsLib PR, googlefonts/glyphsLib#970 is in a release. This will fix the ttx fail. |
I'm spotting some tofu for SSA DinkaNuer when tested with Octo-Text SSA samples |
@vv-monsalve: waiting for @EbenSorkin to provide us with sample texts in the right language, so I can test PRI |
FontBakery reportfontbakery version: 0.12.0a1 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [1] Pacifico-Regular.ttf🔥 FAIL: Ensure the font supports case swapping for all its glyphs. (com.google.fonts/check/case_mapping)
[code: missing-case-counterparts] All other checks[23] Pacifico-Regular.ttf🔥 FAIL: Checking with fontTools.ttx (com.google.fonts/check/ttx_roundtrip)
🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
[code: failed-language-shaping] 🔥 FAIL: Does DESCRIPTION file contain broken links? (com.google.fonts/check/description/broken_links)
🔥 FAIL: Font enables smart dropout control in "prep" table instructions? (com.google.fonts/check/smart_dropout)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
⚠ WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
The following glyphs do not have the recommended number of contours:
Use -F or --full-lists to disable shortening of long lists. ⚠ WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
Use -F or --full-lists to disable shortening of long lists. [code: found-colinear-vectors] ⚠ WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
Use -F or --full-lists to disable shortening of long lists. [code: found-jaggy-segments] ⚠ WARN: Do outlines contain any semi-vertical or semi-horizontal lines? (com.google.fonts/check/outline_semi_vertical)
Use -F or --full-lists to disable shortening of long lists. [code: found-semi-vertical] ⚠ WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
The dot of soft dotted characters should disappear in other cases, for example: ḭ̀ ḭ́ ḭ̂ ḭ̃ ḭ̄ ḭ̆ ḭ̇ ḭ̈ ḭ̉ ḭ̊ ḭ̋ ḭ̌ ḭ̏ ḭ̑ ḭ̒ і̀ і̂ і̃ і̄ і̆ Your font fully covers the following languages that require the soft-dotted feature: Ukrainian (Cyrl, 29,273,587 speakers), Lithuanian (Latn, 2,357,094 speakers), Belarusian (Cyrl, 10,064,517 speakers). Your font does not cover the following languages that require the soft-dotted feature: South Central Banda (Latn, 244,000 speakers), Navajo (Latn, 166,319 speakers), Nzakara (Latn, 50,000 speakers), Ejagham (Latn, 120,000 speakers), Mango (Latn, 77,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Nateni (Latn, 100,000 speakers), Koonzime (Latn, 40,000 speakers), Mfumte (Latn, 79,000 speakers), Dii (Latn, 71,000 speakers), Kom (Latn, 360,685 speakers), Bafut (Latn, 158,146 speakers), Zapotec (Latn, 490,000 speakers), Yala (Latn, 200,000 speakers), Gulay (Latn, 250,478 speakers), Fur (Latn, 1,230,163 speakers), Cicipu (Latn, 44,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Dutch (Latn, 31,709,104 speakers), Bete-Bendi (Latn, 100,000 speakers), Sar (Latn, 500,000 speakers), Avokaya (Latn, 100,000 speakers), Southern Kisi (Latn, 360,000 speakers), Lugbara (Latn, 2,200,000 speakers), Ebira (Latn, 2,200,000 speakers), Ma’di (Latn, 584,000 speakers), Mundani (Latn, 34,000 speakers), Igbo (Latn, 27,823,640 speakers), Dan (Latn, 1,099,244 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Ekpeye (Latn, 226,000 speakers), Aghem (Latn, 38,843 speakers), Makaa (Latn, 221,000 speakers), Basaa (Latn, 332,940 speakers). [code: soft-dotted] ⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
⚠ WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
Use -F or --full-lists to disable shortening of long lists. Or you can add the above codepoints to one of the subsets supported by the font: ⚠ WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
⚠ WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
⚠ WARN: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 65535:
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Familyname must be unique according to namecheck.fontdata.com (com.google.fonts/check/fontdata_namecheck)
[1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
Summary
Note: The following loglevels were omitted in this report:
|
repo url changed, I close this PR and will open a new one |
9cfec57: [gftools-packager] Pacifico: Version 3.010; ttfautohint (v1.8.4.7-5d5b) added
6964840: Description and metadata updated
Closes #7066